| |
| |
| |
|
Page: 1 2
Comments:
<0> _ds, a second pair of eyes are really good in these cases :) especially since when you end up looking at code too similar after a while it's easy to think of it like another part of code
<1> sizeof(blanks) should be strlen(blanks)+1...
<1> (***uming it's made const char [])
<0> i'm not sure where is that you're looking at right now :P so just do what you think it's better :)
<1> src/xitk/main.c, around line 470
<0> _ds, non vedo un sizeof(blanks) ?
<0> err sorry
<0> can't see a sizeof(blanks)
<1> There's a strlen(blanks)...
<0> yes, that one i see
<0> that blanks should be a static const, too
<0> _ds, tell me when you've finished your p*** of the polishing, that i'll see to put a new snapshot in portage, as i fixed building on fbsd too, compared to latest snapshot
<0> and this time it does not seem to export any symbol, so i can drop the -fvisibility using on gcc 4.1
<1> I don't suppose that BSD has an slprintf...?
<0> well slprintf does not concatenate, so has not much use for it :)
<1> Hmm... I'd probably have added a macro to make most of those strlen() calls implicit...
<0> i don't like macros too much, i prefer leaving to the compiler taking care of summarising them
<1> Pointless change at src/xitk/keybindings.c:620. Yes, it's a strcat, but the buffer is exactly the right size...
<1> (Er. kbindings.c.)
<0> _ds, just wanted to be sure tbh :P
<1> It occurs to me that that BSD-licensed file requires a change in debian/copyright...
<1> siretart?
<0> _ds, hm? why? when used with the whole source of xine-ui it falls in gpl-2 licensing
<1> The source file does? That's fine, then.
<0> well it also seems more as-is than bsd license, for that file, tbh
<0> as there's no clause at all
<0> but in general, the whole package is licensed under gpl-2, so it falls under that, although you can take the _single_ source file and then use it as bsd/as-is licensed, but not with the rest of the source
<0> [that is at least what happens with binutils now]
<0> (binutils 2.17 have a bsd-licensed header file shipped with them)
<0> _ds, hm if that happens, there's something really broken, but you're right, should probably use -1 and set the latest byte to 0
<1> The instance which I'm looking at seems harmless anyway.
<1> (src/fb/osd.c:396)
<1> I wonder why there isn't a variadic (well, printf-like) version of xine_osd_draw_text...
<1> Or if there is, why it isn't used there.
<1> ... hmm, should have known, xine-lib function. Oh well. Time to add it, I think :-)
<0> if you add it to 1.1.3 you need to change the version requirment for xine-ui
<0> which i'm not sure it's a good idea
<1> Well... if xine-ui starts using it, anyway :-)
<0> not until 0.99.5 is released at least
<1> I'd be interested to know what coverity has to say about gxine, and how much of it is already fixed :-)
<1> Hmm, looks like the title truncation isn't right. Normally, you want "%*s..." for that kind of thing...
<1> (src/xitk/xine-toolkit/image.c:_draw_frame())
<0> _ds, you're right
<1> xitk_font_get_string_length probably needs a third parameter
<1> (string length)
<1> Various GLib functions have that, taking -1 == use strlen(), and it's quite useful :-)
<1> (Well, -1 effectively being strlen(); it's reasonable to terminate on NUL regardless.)
<1> Hmm. I don't think that xine's menus are meant to have frames :-)
<1> (xfwm4 4.3.90.2ish)
<1> ... right, patch check done :-)
<1> (I'd use asprintf, but that's GNU/BSD only, according to the man page.)
<2> uh, is it GNU only or BSD only?
<1> Both.
<2> where "BSD only" doesn't make a particular amount of sense
<0> Triskelios, there are functions that are bsd only
<1> As in "not known to be available elsewhere".
<0> and asprintf is not available mainly on solaris and win32
<2> oh sorry, I was seriously confused. for a moment I thought it was a licence reference
<0> i could easily add an asprintf replacement probably anyway
<2> nevermind =P
<1> Flameeyes, worth doing within xine-lib?
<0> _ds, what? asprintf? nop, shouldn't be exported
<1> Should be usable internally and, ideally, by plugins.
<0> should be in a commodity library, static inside the plugins
<0> shouldn't be an extra dependency between library and plugins
<1> If the plugin version requirement is bumped, that shouldn't matter; anyway, we could call it _x_asprintf or something, and just #define it as asprintf where that is available.
<1> Come to think of it, a vasprintf implementation would be needed too...
<0> _ds, having a _x_asprintf exported by libxine would be a bad design choice imho
<0> damn to "make dist" regenerating .po files
<0> it is a useful behaviour
<0> but i just committed the regen with another change
<1> :-\
<1> You'll be making use of 'cvs admin' now, I expect... :-)
<0> for .po files? :P never
<0> +capable
<0> not by me :P not for now at least
<0> although it might be good before 0.99.5 release
<0> and that is a long overdue release
<1> Uninteresting factoid: 3 releases of xine-ui and 20 of gxine since Nov 2004...
<3> _ds: yes?
<3> oh licencing issues. I see..
<4> can i skip/toggle chapters on a dvd movie back/foreward?
<5> Hey when doing xine_set_param (_stream, XINE_PARAM_EQ_60HZ, (-100)); and xine_set_param (_stream, XINE_PARAM_EQ_60HZ, 100); it looks like the resulting sound is the same?
<6> hi. i would like to have ui window hide/showed after clicking on middle mouse button (scroll button). I have ***ignet that shortcut in configuration however it doesn't work the way it should. After clicking the button and holding it (click!) the ui disapears, but after taking finger off (clack!) ui is getting back :/
<6> ohhh... forget my question, it works now :)
<5> Hey when doing xine_set_param (_stream, XINE_PARAM_EQ_60HZ, (-100)); and xine_set_param (_stream, XINE_PARAM_EQ_60HZ, 100); it looks like the resulting sound is the same? (as in both cases the change is the same). Is that supposed to be so? Also if I have a vertical scale/slider is -100 at the bottom, 0 in the middle, +100 at the top ?
<7> hi, I have some trouble with gxine and DVB here is what I get: http://pastebin.4programmers.net/269, where I m wrong ? thx
<1> Hmm, nothing wrong that I can see there (except that your channels.conf is world-writable).
<1> Permissions problem on /dev/dvb/adapter0/* ?
<1> Or maybe you don't have group access to those device nodes...?
<7> no permissions problem :/
<1> Is media.dvb.adapter pointing at the right device no.? (Actually, this needs to be fixed wrt device initialisation order...)
<7> sorry, where can i find media.dv.adapter ? (not in .xine/catalog.cache)
<1> Preferences window.
<7> yes adapter is at 0
<1> Could you try again with "gxine -v"?
<7> good !! :)
<1> Hmm?
<7> what's the difference, it's works
<1> Not sure. I've seen a report of this before...
<7> i don't understand
<7> why
<7> but it works
<1> </AOL> - it works for me without -v (UK Freeview).
<7> It's very strange, maybe the verbose option allow someting needed in the code ?
<1> That seems likely.
<7> i will try to search
<1> Eek, SF p***word expiry...
<1> BTW, which version of gxine?
<1> (Need to update a bug report)
<7> gxine 0.5.7
<3> hi
<1> Right. Bug 1256851 is reopened.
<3> _ds: you highlited me yesterday about a licence change?
<1> siretart: just one file, but it seems to be resolved.
<3> ah. nice
<5> Hey when doing xine_set_param (_stream, XINE_PARAM_EQ_60HZ, (-100)); and xine_set_param (_stream, XINE_PARAM_EQ_60HZ, 100); it looks like the resulting sound is the same? (as in both cases the change is the same). Is that supposed to be so? Also if I have a vertical scale/slider is -100 at the bottom, 0 in the middle, +100 at the top ?
<3> _ds: is there another patch, which should go into the xine-ui 0.99.4 package?
<1> siretart, probably worth looking at the patches which were committed yesterday.
<1> Might be better to go with a CVS snapshot, though.
<3> I've just prepared an cvs snapshot, but I've been rather thinking about uploading it to experimental first
<3> btw, how about preparing a maintainer upload of gxine?
<3> it hasn't seen a maintainer upload since quite some time..
<1> Awaiting sponsorship ATM.
<1> (Sponsor has replied.)
<3> Ic. whom did you ask?
<1> Laszlo Boszormenyi.
<3> ah. ok
<1> When xfwm4 4.3.90.2 makes it into sid, hopefully we'll have gxine 0.5.7 and xine-ui > 0.99.4 there too...
<1> Reason is translucency of inactive windows.
<3> just release xine-ui 0.99.5 ;)
<1> Probably. Somebody else's problem, though :-)
<3> on the other hand, if some testers other than me would tell me they tested a particular snapshot, and upstream (read: you) are confident with the snapshot that it would be suitable for a debian release, I'd have no problems uploading it to unstable as well
<8> hi
<8> the xine engine fails to start when i insert a DVD
<8> no demuxer found - stream format not recognized
<8> is the demuxer the decoder?
<0> SurfnKid, which distribution, which xine-lib version, and how did you install it?
<8> how come it works after, when I selecct DVD
Return to
#xine
or
Go to some related
logs:
libexpat.so xfce4 emerge
#perl
#ubuntu
#math
cpufreq ubuntu analyzing CPU 0:
no or unknown cpufreq driver is active on thi
#math
#suse
#perl
Debian VITESSE VSC8201 LAN
#osdev
|
|